{5} Accepted, Active Tickets by Owner (Full Description) (5 matches)

List tickets accepted, group by ticket owner. This report demonstrates the use of full-row display.

cmontedonico (1 match)

Ticket Summary Component Milestone Type Created
Description
#62 Create list of missing sections from PHPT PHPT_Core Google Summer of Code task 05/27/08

There are several sections that are implemented in PHP's run-tests.php code that are not currently present in PHPT. We need to compile a list of them here so we can determine what are missing.

ezyang (1 match)

Ticket Summary Component Milestone Type Created
Description
#43 SectionList ->filterByInterface should return resultset, not modify object PHPT_Core defect 02/16/08

Currently, the method filterByInterface in SectionList modifies an internal buffer _sections, making the "contents" of SectionList change according to the filtering method.

This is a nice "trick", but runs into bugs if, while iterating over SectionList, the internal cursor is fiddled with. In fact, this is the case if one attempts to get SKIPIF to use CodeRunner; the cursor gets reset, and consequently there is an infinite loop.

There are two ways to fix this: use an external iterator, or modify filterByInterface so that it returns a SectionList with the reduced interface. I have opted to do the latter: the implementation is a bit simpler, still makes sense, and does not incur any performance impact (as, previously speaking, we were still copying out the sections we wanted).

tswicegood (3 matches)

Ticket Summary Component Milestone Type Created
Description
#49 Executable path checking doesn't handle absolute paths PHPT_Core PHPT_Core 0.2 defect 02/16/08

PHPT_CodeRunner_Driver_Proc and PHPT_CodeRunner_Driver_WScriptShell contain a validate() function which tests for the PHP executable by searching for it in various paths. However, if the executable is specified from the root directory (such as /usr/bin/php), the driver throws an error stating "unable to locate PHP executable". This can be fixed by directly checking the executable before looping through the search paths in $PATH.

#73 Missing argument in new PHPT_CodeRunner_ExecutionException call PHPT_Core PHPT_Core 0.2 defect 06/30/08

WScriptShell.php does:

throw new PHPT_CodeRunner_ExecutionException($error);

PHPT_CodeRunner_ExecutionException constructor is:

public function construct($message, $executable)

Obviously, $executable needs to be made optional (or it needs to be sent in from WScriptShell.php.

#47 Ampersands must be escaped in environment for Windows PHPT_Core PHPT_Core 0.2 defect 02/16/08

WScriptShell->_buildEnvironmentString doesn't escape ampersands, so if any environment variable contains an ampersand some side-effects can occur. Add $value = str_replace('&', '^&', $value); before $return .= ... to fix this.

Note: See TracReports for help on using and creating reports.